aminghadersohi commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4173313157
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/controlPanel.ts:
##########
@@ -59,6 +59,19 @@ const config: ControlPanelConfig = {
['adhoc_filters'],
[tooltipContents],
[tooltipTemplate],
+ [
+ {
+ name: 'mcp_geographic',
+ config: {
+ type: 'HiddenControl',
+ hidden: true,
+ renderTrigger: false,
+ description: t(
+ 'Marks charts created through the MCP geographic contract so
Explore keeps their validation guards.',
+ ),
+ },
+ },
+ ],
Review Comment:
Valid, and introduced by this PR (the marker was added to all three control
panels). Fixed in 065a6b3ada40e3b86c496fbe505a6f95a0c7f5dc: the hidden
`mcp_geographic` control is now declared once in `@superset-ui/chart-controls`
shared controls (same pattern as `temporal_columns_lookup`) and the world map,
country map and deck.gl scatter panels reference it by name. `Shared_DeckGL`
was not used because the world/country map plugins cannot import from the
deck.gl package; chart-controls is a dependency of all three.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
