bito-code-review[bot] commented on code in PR #44148:
URL: https://github.com/apache/superset/pull/44148#discussion_r4173109164
##########
superset-frontend/plugins/preset-chart-deckgl/src/layers/Scatter/controlPanel.ts:
##########
@@ -59,6 +59,19 @@ const config: ControlPanelConfig = {
['adhoc_filters'],
[tooltipContents],
[tooltipTemplate],
+ [
+ {
+ name: 'mcp_geographic',
+ config: {
+ type: 'HiddenControl',
+ hidden: true,
+ renderTrigger: false,
+ description: t(
+ 'Marks charts created through the MCP geographic contract so
Explore keeps their validation guards.',
+ ),
+ },
+ },
+ ],
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Duplicated hidden control</b></div>
<div id="fix">
This `mcp_geographic` HiddenControl block is duplicated verbatim in
`plugin-chart-world-map/src/controlPanel.ts` (L58-70) and
`plugin-chart-country-map/src/controlPanel.ts` (L74-86). Since this file
already imports shared controls from `../../utilities/Shared_DeckGL`, hoist the
definition there and reuse it to avoid three copies of the same marker drifting
apart.
</div>
</div>
<small><i>Code Review Run #3d65e9</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
