FrancescoCastaldi commented on PR #44464: URL: https://github.com/apache/superset/pull/44464#issuecomment-5967902846
Addressed review suggestions in commit [fca3591](https://github.com/apache/superset/commit/fca3591ae6eb722b5e28a9b2c342f567b57da001): 1. `superset/mcp_service/chart/schemas.py`: updated `XYChartConfig.sort_by` annotation to `SortByConfig | str | Tuple[str, bool] | Annotated[List[SortByConfig | str], Field(max_length=1)] | None`. This ensures `[col, asc]` validates cleanly against `Draft202012Validator` and advertises the single-sort-column constraint (`maxItems=1`) in the generated JSON schema. 2. `tests/unit_tests/mcp_service/chart/test_chart_schemas.py`: added `test_sort_by_pair_format_valid_against_json_schema` to verify schema validation for the pair format. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
