aminghadersohi commented on code in PR #44464:
URL: https://github.com/apache/superset/pull/44464#discussion_r4173108094
##########
superset/mcp_service/chart/schemas.py:
##########
@@ -1095,6 +1095,10 @@ class SortByConfig(UnknownFieldCheckMixin):
description="Sort ascending. Defaults to False (descending) to match "
"the typical sort-by-metric top-N use case.",
)
+ saved_metric: bool | None = Field(
Review Comment:
Required `unit-tests` fails: https://github.com/apache/superset/pull/44573
(on master) bans null schema defaults and this one lands in
`$defs/SortByConfig`. After merging master, add `OmittedMeansUnchanged` to
`SortByConfig`'s bases (no fence: that line is outside the diff).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
