rabumaabraham commented on code in PR #44803:
URL: https://github.com/apache/superset/pull/44803#discussion_r4172621166
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -391,12 +391,9 @@ const FilterBar: FC<FiltersBarProps> = ({
}
});
- // Remove stale entries that no longer exist in dataMaskApplied
+ // Remove stale entries that no longer exist in the configured filters
Object.keys(updated).forEach(filterId => {
Review Comment:
Addressed. I added handling for the `true → false` cross-filtering
transition so that `dataMaskSelected` is cleared when cross-filtering is
disabled.
I also added a regression test covering this case. The test passes locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
