sadpandajoe commented on code in PR #44803:
URL: https://github.com/apache/superset/pull/44803#discussion_r4174951472
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx:
##########
@@ -1232,7 +1254,7 @@ test('required filter with a default value auto-applies
on load without touching
// Nothing is left pending: the default value is already applied, so the
// Apply button is not blocking on untouched filters.
- expect(screen.getByTestId(getTestId('apply-button'))).toBeDisabled();
+ expect(screen.getByTestId(getTestId('apply-button'))).toBeEnabled();
Review Comment:
This now enables Apply on initial load even though the required default is
already applied and the optional filter was never touched: retaining its empty
selected mask makes `{}` differ from the absent applied entry. Could we
normalize that no-op state and keep the no-pending assertion disabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
