sadpandajoe commented on code in PR #44803:
URL: https://github.com/apache/superset/pull/44803#discussion_r4172167736
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -391,12 +391,9 @@ const FilterBar: FC<FiltersBarProps> = ({
}
});
- // Remove stale entries that no longer exist in dataMaskApplied
+ // Remove stale entries that no longer exist in the configured filters
Object.keys(updated).forEach(filterId => {
Review Comment:
Disabling Enable cross-filtering clears the Redux masks via
`clearDataMaskState()`, but the native filters remain configured, so this now
retains the old time-range label while charts run without that predicate; the
next Apply restores it. Could explicit applied-state resets also reset the
selected state?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
