bito-code-review[bot] commented on PR #44955:
URL: https://github.com/apache/superset/pull/44955#issuecomment-5972402575
<!-- Bito Reply -->
The flagged issue is correct. When `setColumnConfig` is called with
`col.name` (which may be an alias like 'Time'), it overwrites the configuration
for that key, potentially discarding existing settings stored under the actual
column key (e.g., `__timestamp`).
To resolve this, ensure the `onChange` callback preserves existing
configuration properties by merging the new config with the existing one. You
can update the `onChange` handler in `ColumnConfigControl.tsx` as follows:
```tsx
onChange={config => setColumnConfig(col.key, { ...col.config, ...config } as
T)}
```
There are no other comments on this PR to address.
**superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx**
```
onChange={config => setColumnConfig(col.key, { ...col.config, ...config } as
T)}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
