AmoghAtreya commented on code in PR #44955:
URL: https://github.com/apache/superset/pull/44955#discussion_r4174506101
##########
superset-frontend/src/explore/components/controls/ColumnConfigControl/ColumnConfigControl.tsx:
##########
@@ -147,7 +148,7 @@ export default function ColumnConfigControl<T extends
ColumnConfig>({
<ColumnConfigItem
key={col.name}
column={col}
- onChange={config => setColumnConfig(col.name, config as T)}
+ onChange={config => setColumnConfig(col.key, config as T)}
Review Comment:
Resolved - `normalizeColumnConfigKeys` now remaps `COLUMN_NAME_ALIASES`
display names (e.g. `"Time"` → `__timestamp`), same as the existing Main-key
migration. Tests cover the remap and the control migration path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
