AmoghAtreya commented on code in PR #44955:
URL: https://github.com/apache/superset/pull/44955#discussion_r4187505695
##########
superset-frontend/packages/superset-ui-chart-controls/src/utils/headerGroups.ts:
##########
@@ -341,10 +344,18 @@ export function normalizeColumnConfigKeys<T>(
return {};
}
const colnamesSet = new Set(colnames);
+ const aliasToKey = new Map(
Review Comment:
Thanks for the review! Just resolved this error.
`normalizeColumnConfigKeys` now matches both the English source string
(`Time`) and `t('Time')`, and it remaps only when that key is not a real
column/metric name. A current or dropped `Time` column stays put even if
`__timestamp` is in the result; a translated alias still migrates.
Table and AG Grid `transformProps` use the same normalization when reading
`column_config`, so legacy `Time` settings apply on render without waiting for
another edit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
