sadpandajoe commented on code in PR #43695:
URL: https://github.com/apache/superset/pull/43695#discussion_r4174713005
##########
superset/db_engine_specs/parseable.py:
##########
@@ -41,16 +41,19 @@ class ParseableEngineSpec(BaseEngineSpec):
"Parseable is a distributed log analytics database "
"with SQL-like query interface."
),
+ "logo": "parseable.png",
+ "homepage_url": "https://www.parseable.com";,
"categories": [DatabaseCategory.SEARCH_NOSQL,
DatabaseCategory.OPEN_SOURCE],
"pypi_packages": ["sqlalchemy-parseable"],
"connection_string": (
- "parseable://{username}:{password}@{hostname}:{port}/{stream_name}"
+
"parseable+http://{username}:{password}@{hostname}:{port}/{stream_name}";
),
+ "default_port": 8000,
"connection_examples": [
{
"description": "Example connection",
"connection_string": (
-
"parseable://admin:[email protected]:443/ingress-nginx"
+
"parseable+http://admin:[email protected]:443/ingress-nginx";
Review Comment:
The `+http` scheme forces plain HTTP even on port 443, so this example fails
against an HTTPS listener instead of using TLS as before. Could the demo
example retain `parseable+https://` while the port-8000 template uses HTTP?
##########
superset/db_engine_specs/lint_metadata.py:
##########
@@ -272,10 +276,17 @@ def get_all_engine_specs_ast() -> list[dict[str, Any]]:
# noqa: C901
if isinstance(item, ast.Assign):
for target in item.targets:
if isinstance(target, ast.Name) and target.id ==
"engine":
- # Check if engine value is non-empty string
if isinstance(item.value, ast.Constant):
has_non_empty_engine =
bool(item.value.value)
break
+ elif isinstance(item, ast.AnnAssign):
Review Comment:
Both fixtures now lack the `BaseEngineSpec` suffix, so they bypass the
filter: removing annotated-engine handling still leaves their
discovery/name/metadata assertions passing, while `TypedBaseEngineSpec`
disappears. Could both fixtures use that suffix so the initialized and
declaration-then-assignment cases protect engine discovery?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
