madhushreeag commented on code in PR #44365:
URL: https://github.com/apache/superset/pull/44365#discussion_r4191914974
##########
superset/security/api.py:
##########
@@ -268,6 +285,140 @@ def guest_token(self) -> Response:
except ValidationError as error:
return self.response_400(message=error.messages)
+ @expose("/login-token/", methods=("POST",))
+ @event_logger.log_this
Review Comment:
Fixed - `auth_user_oauth` selects on key *presence* (`if "username" in
userinfo`), so an empty value wins over the email and is then rejected, 401ing
a token that minted fine. `resolve_identity` now strips string values and drops
empty ones *before* the usable-identifier check, so `{"username": "", "email":
...}` falls through to the email, and `" jdoe "` no longer misses
`find_user`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
