madhushreeag commented on code in PR #44365:
URL: https://github.com/apache/superset/pull/44365#discussion_r4191928448
##########
superset/security/api.py:
##########
@@ -268,6 +285,140 @@ def guest_token(self) -> Response:
except ValidationError as error:
return self.response_400(message=error.messages)
+ @expose("/login-token/", methods=("POST",))
+ @event_logger.log_this
Review Comment:
Swapped to `log_this_with_context(action=..., include_request_data=False)`,
keeping the action name for the audit trail but dropping
form/query/JSON/referrer, on rejection as well as success. Agreed on the
reasoning: the mint body is the one place an upstream credential can appear,
and the one-time token's TTL says nothing about that credential's lifetime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
