mikebridge commented on PR #44452: URL: https://github.com/apache/superset/pull/44452#issuecomment-6047059907
@rebenitez1802 thanks for the detailed review. Here is what changed for each point, in [29a85fa](https://github.com/apache/superset/commit/29a85fa9977907654922fce150472351f0d7bbba): - ControlHeader a11y: noninteractive headers now render as plain text, while interactive headers keep keyboard activation. - Stale-datasource gating: when the datasource types disagree, the pagination gate now follows `form_data`, with tests covering both switch directions. - Description: the private reference has been scrubbed from the PR description. - Nits: the optional capability opt-in, provider-owned offset/limit validation, themed feedback, the unlabeled reset, saved AG Grid offsets, and no reset flicker while metadata loads are all done. Saved pagination values remain unchanged until an explicit edit. [37f79ac](https://github.com/apache/superset/commit/37f79acf4bff009b16d66e16ba969feb900b777d) also updates two consumer tests that still assumed those labels were buttons. Could you take another look when you have a moment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
