mikebridge commented on PR #44452: URL: https://github.com/apache/superset/pull/44452#issuecomment-6083994263
@geido Follow-up: the label/reason item I flagged in my previous comment is fixed in `a6c46eac4f`. `hasMatchingDatasourceMetadata` is now the single predicate behind all three decisions — the capability check, `disabledReason` and `resetLabel` — in both the Table and AG Grid control panels. So while metadata is pending or belongs to a previously selected view, the control is disabled with no explanation and no reset offer, instead of describing the selected view using another view's metadata. Once the UID matches the selection, both strings appear as before. The parametrized `withholds pagination advice for stale metadata …` tests pin the whole transition for both canonical (`1__semantic_view` → `2__semantic_view`) and opaque (`cube__orders` → `cube__customers`) UIDs, and the two pending-metadata tests now assert the neutral reason as well. Six tests fail without the change; both control-panel suites are 65/65 with it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
