mikebridge commented on code in PR #44452: URL: https://github.com/apache/superset/pull/44452#discussion_r4221624646
########## superset-frontend/packages/superset-ui-chart-controls/src/utils/isServerPaginationUnsupported.ts: ########## @@ -0,0 +1,40 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { DatasourceType } from '@superset-ui/core'; +import type { ControlPanelState } from '../types'; + +/** SemanticViewFeature value for providers that support row offsets. */ +export const ROW_OFFSET = 'ROW_OFFSET'; + +/** Keep semantic pagination disabled until the view declares offset support. */ +export function isServerPaginationUnsupported({ + datasource, + form_data, +}: ControlPanelState): boolean { + const datasourceType = + form_data.datasource?.split('__')[1] ?? datasource?.type; Review Comment: Good catch, addressed in `8a1d5f0f07` using your UID-match suggestion. Table and AG Grid both handle `cube__orders` correctly with and without ROW_OFFSET. Removing the fix fails four new cases; with it in place, all six UID cases and the four stale-metadata cases pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
