dmunozv04 opened a new pull request, #45142:
URL: https://github.com/apache/superset/pull/45142

   <!---
   Please write the PR title following the conventions at 
https://www.conventionalcommits.org/en/v1.0.0/
   Example:
   fix(dashboard): load charts correctly
   -->
   
   ### SUMMARY
   
   When selecting a dashboard filter in a report, the value dropdown appears 
unavailable while its options load, with no clear loading feedback. If loading 
fails, the user also needs an explanation. This also affects saved reports when 
their filter options are loaded for editing as well.
   
   The loading failed inline errors on filters borrows the logic from the 
recently merged #44585 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   #### Dashboard filter doesn't show a loading indicator
   Before:
   
   
https://github.com/user-attachments/assets/9556f1c9-cbfd-4cc1-b9de-27147c032f32
   
   After:
   
   
https://github.com/user-attachments/assets/860c1fdf-a703-4dcb-917b-3451dc8ba087
   
   #### Dashboard filter that fails fetching errors without any message (aside 
from the debug error)
   Before:
   
   
https://github.com/user-attachments/assets/367a3929-6d2f-4afe-b078-8120b7fed9c5
   
   After:
   
   
https://github.com/user-attachments/assets/9d91f1b4-a8a3-48d0-8ef7-ea66566b541c
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [X] Has associated issue: #45141
   - [X] Required feature flags: `ALERT_REPORTS`, `ALERT_REPORTS_FILTER`
   - [X] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to