codeant-ai-for-open-source[bot] commented on code in PR #45142:
URL: https://github.com/apache/superset/pull/45142#discussion_r4231705548
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -1864,6 +1940,30 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
const renderFilterValueSelect = (filter: ExtraNativeFilter, idx: number) => {
if (!filter) return null;
+ const filterError = nativeFilterErrors[filter.nativeFilterId ?? ''];
+ if (filterError) {
+ const { error, isNetworkError } = filterError;
+ return (
+ <ErrorMessageWithStackTrace
+ error={error.errors?.[0]}
+ compact
+ fallback={
+ <ErrorAlert
+ errorType={
+ isNetworkError ? t('Network error') : t('Cannot load filter')
+ }
+ message={
+ isNetworkError
+ ? t('Network error while attempting to fetch resource')
+ : t('Sorry, something went wrong. Try again later.')
+ }
+ type="error"
+ compact
+ />
+ }
+ />
+ );
+ }
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `cb5b657`.
The `filter_range` branch now renders the manual min/max inputs and returns
before the native-filter error check, so a failed options request does not
replace those inputs with an error.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
