sadpandajoe commented on code in PR #45142:
URL: https://github.com/apache/superset/pull/45142#discussion_r4233337754
##########
superset-frontend/src/features/alerts/AlertReportModal.test.tsx:
##########
@@ -2221,6 +2221,311 @@ test('filter reappears in dropdown after clearing with
X icon', async () => {
);
}, 45000);
+test.each(['older', 'latest'] as const)(
Review Comment:
The overlapping-request cases only resolve both requests successfully, so
nothing exercises the `isLatestRequest()` guard in `handleError`. If that guard
were dropped, an older request rejecting after the latest one succeeds would
replace the loaded options with an inline error, and these tests would still
pass. Could you add a case where the older deferred request rejects after the
latest resolves, asserting that `Latest country` is still selectable and no
error title is rendered?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
