mikebridge commented on PR #42760:
URL: https://github.com/apache/superset/pull/42760#issuecomment-6083350396
Pushed f90b19ee76, which brings in master and fixes one cache-identity gap.
- **Master merge:** master's completeness check now runs inside the
containment cache's provider dispatch, which is the miss path. An incomplete or
rejected provider result raises before anything is stored.
- **Containment identity:** it now includes the same producer result-version
discriminator that master added to the direct result cache key
(`("semantic-result-version", layer type, version)`). Results stored under an
older producer guarantee can no longer be reused through a containment hit.
Layers without a version keep their existing identity.
- **Tests:** the discriminator partitions the containment definition
identity, and a version change forces a miss and then a hit. A provider
rejection or completeness error on a miss is raised, not cached, and the next
successful query is stored normally.
Still on hold until the metadata-cache invalidation work lands; containment
composes with its generation token. One docs-only conflict with master remains
in `docs/developer_docs/extensions/contribution-types.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
