FrancescoCastaldi commented on PR #44464: URL: https://github.com/apache/superset/pull/44464#issuecomment-6083847268
Thanks @aminghadersohi for catching both merge leftovers. Both points have been resolved in commit d8a08f65f8: 1. Removed the extra third blank line in `superset/mcp_service/chart/chart_helpers.py`, bringing it back to standard PEP 8 spacing so `ruff format --check` passes cleanly. 2. Updated `test_build_query_dicts_from_form_data_xy_bar_explore_default_grain` in `tests/unit_tests/mcp_service/chart/test_chart_helpers.py` to validate against the post-PR #43771 contract, checking the axis dict column structure and the sort operator inside `post_processing`. Regarding `build_single_query_dict`: good catch that XY charts now flow entirely through `form_data_query_context` via `build_query_objects_from_form_data`. If you prefer pruning that branch and helper from `build_single_query_dict` completely, let me know and I will gladly drop it. All relevant unit tests (337 schema and util tests, plus all sort tests) pass locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
