sadpandajoe commented on code in PR #45142:
URL: https://github.com/apache/superset/pull/45142#discussion_r4237696426
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -1924,6 +1979,52 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
</div>
);
}
+ const filterError = nativeFilterErrors[filter.nativeFilterId ?? ''];
+ if (filterError) {
+ const { error, isNetworkError } = filterError;
+ return (
+ <ErrorMessageWithStackTrace
Review Comment:
`ErrorMessageWithStackTrace` defaults to `closable`, and registered handlers
such as the timeout one render a dismissible alert (the `compact` fallback is
only used for unregistered errors). If the options request times out and the
user clicks the close button, the error stays in `nativeFilterErrors` but the
alert disappears, so the Value cell is blank and the `Select` never comes back
for that row. Should this pass `closable={false}` so the error stays visible
until the filter is re-selected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
