codeant-ai-for-open-source[bot] commented on code in PR #45173:
URL: https://github.com/apache/superset/pull/45173#discussion_r4239397918
##########
superset-frontend/src/features/semanticLayers/jsonFormsHelpers.tsx:
##########
@@ -227,18 +290,20 @@ export function DynamicFieldControl(props: ControlProps) {
);
if (enumValues && enumValues.length > 0) {
- const tooltip = (props.uischema?.options as Record<string, unknown>)
- ?.tooltip as string | undefined;
const placeholder = (props.uischema?.options as Record<string, unknown>)
?.placeholderText as string | undefined;
return (
- <FormItem label={props.label} tooltip={tooltip}>
+ <FormItem
+ label={props.label}
+ extra={props.schema.description}
+ required={props.required}
+ >
<Select
ariaLabel={props.label || undefined}
value={(props.data as string | number | undefined) ?? undefined}
onChange={value => props.handleChange(props.path, value)}
options={options}
- disabled={!props.enabled || refreshing}
+ disabled={!props.enabled}
Review Comment:
**Suggestion:** Dynamic enum controls stay interactive during refresh, so
changing dependencies can start overlapping requests and an older response can
overwrite the newer schema with stale choices.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Race condition`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=62cf0fb48a0a46fd866b64bef05e7b6b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=62cf0fb48a0a46fd866b64bef05e7b6b&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/features/semanticLayers/jsonFormsHelpers.tsx
**Line:** 306:306
**Comment:**
*Race Condition: Dynamic enum controls stay interactive during refresh,
so changing dependencies can start overlapping requests and an older response
can overwrite the newer schema with stale choices.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45173&comment_hash=fa773361618b9c0f033c203a3c75742187a00542aa850d9eb7477bb079f165e3&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45173&comment_hash=fa773361618b9c0f033c203a3c75742187a00542aa850d9eb7477bb079f165e3&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
