aminghadersohi commented on code in PR #45173:
URL: https://github.com/apache/superset/pull/45173#discussion_r4253153134
##########
superset-frontend/src/features/semanticLayers/SemanticLayerModal.tsx:
##########
@@ -321,13 +349,11 @@ export default function SemanticLayerModal({
addSuccessToast(t('Semantic layer created'));
}
onHide();
- } catch (error) {
- const clientError = await getClientErrorObject(error);
+ } catch {
Review Comment:
This drops the 422 reasons the user needs in order to act: `Name already
exists: …`, `Invalid configuration: auth.private_key: missing`, and the update
guard that rejects an edit reusing a masked secret ("Provide the real value for
any masked field"). The backend already sanitizes these:
`validate_configuration` keeps only loc/type and maps provider exceptions to
fixed text. Without the reason, a user who edits the host and leaves the token
masked can't tell what to fix. Could Save keep
`getClientErrorObject(error).error` and fall back to the generic string only
when it's empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
