mikebridge commented on code in PR #45173:
URL: https://github.com/apache/superset/pull/45173#discussion_r4249780295
##########
superset-frontend/src/features/semanticLayers/jsonFormsHelpers.tsx:
##########
@@ -227,18 +290,20 @@ export function DynamicFieldControl(props: ControlProps) {
);
if (enumValues && enumValues.length > 0) {
- const tooltip = (props.uischema?.options as Record<string, unknown>)
- ?.tooltip as string | undefined;
const placeholder = (props.uischema?.options as Record<string, unknown>)
?.placeholderText as string | undefined;
return (
- <FormItem label={props.label} tooltip={tooltip}>
+ <FormItem
+ label={props.label}
+ extra={props.schema.description}
+ required={props.required}
+ >
<Select
ariaLabel={props.label || undefined}
value={(props.data as string | number | undefined) ?? undefined}
onChange={value => props.handleChange(props.path, value)}
options={options}
- disabled={!props.enabled || refreshing}
+ disabled={!props.enabled}
Review Comment:
Good catch—the debounce only cancelled pending timers; it did not fence
requests already in flight. Fixed in dc25bc9eb2554bf30302eacbcd96f61ce42cb91b
with a separate schema-request generation that invalidates older responses as
soon as dependencies change, including during debounce, and ignores their
schema/error/loading updates. Fields remain editable; requests are not
network-aborted. Nine red-first regression cases and all 73 focused frontend
tests pass. Implemented with Codex and independently reviewed by Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
