rusackas commented on PR #44279: URL: https://github.com/apache/superset/pull/44279#issuecomment-6123929128
Thanks for this, the form round trip and the broker/router port hint are nice touches. One thing I'd want sorted before we merge: a saved Druid URI with no port (`druid://host/druid/v2/sql/`) gives `port=None` from `get_parameters_from_uri`, and the schema's required `port` will reject that, so those connections can't be edited through the form. Could we allow None there or fall back to a default? Also worth a quick look at the two Bito nits (the duplicated field components and the test annotations). The `database` thread looks fixed by `unknown = EXCLUDE`, so that one can be resolved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
