eschutho commented on PR #44279: URL: https://github.com/apache/superset/pull/44279#issuecomment-6199354084
@rusackas thanks. Fixed in 609cd6b69c: saved Druid URIs without an explicit port now default to the broker port 8082 in `get_parameters_from_uri`, so the required port field loads and those connections can be edited through the form. An explicit port is still kept as is. There's a test covering both `druid://` and `druid+https://` URIs with no port. The two Bito nits are addressed in dcf305a7b0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
