rusackas commented on PR #44279: URL: https://github.com/apache/superset/pull/44279#issuecomment-6124721498
Heya @eschutho, the `port=None` case for saved Druid URIs with no explicit port is the one thing keeping this from being ready. Allowing None there or falling back to the broker default (8082) would sort it. Otherwise this looks about ready, and the two Bito nits are worth a quick look too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
