mikebridge commented on code in PR #44393:
URL: https://github.com/apache/superset/pull/44393#discussion_r4249865279
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -327,6 +327,44 @@ Permissions and row-level security apply exactly as they
do without it.
---
+## Semantic-view chart targets
+
+`generate_chart` and `generate_explore_link` require exactly one source
selector:
+`dataset_id` for a table dataset, or `view_id` for a semantic view. View
selectors
+accept UUIDs or legacy numeric IDs. The numeric ID spaces are independent: a
+dataset ID must not be reused as a view ID.
+
+The legacy `datasource_id` alias defaults to a table when `datasource_type` is
+omitted. With `datasource_type: "semantic_view"`, it selects a view instead.
+For table-only requests, an explicit `dataset_id` takes precedence over
+`datasource_id`. Unsupported types and conflicting semantic selectors are
rejected.
+
+Semantic configurations use saved metric names, for example
+`{"name": "revenue", "saved_metric": true}`, and dimensions published by the
view.
+Ad-hoc aggregates and SQL expressions are rejected. Missing and inaccessible
+views return the same `view_not_found` error without exposing view metadata.
+
+`update_chart` accepts at most one replacement selector; omitting both retains
+the chart's source. Rebinding validates retained query roles, preserves the
+selected source family in previews and stored parameters, and clears stale
+query context. An incompatible retained configuration must be replaced with a
Review Comment:
Good catch—applied your suggested wording in
aa786c30d93bc75fb3132536faa7fca47313fbcd. Verified that dataset rebinds,
including view-to-table, require a complete config, while supported view-only
rebinds validate retained roles. Geographic, gauge, and treemap charts still
require config for view rebinds as well.
Implemented with Codex and independently reviewed with Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
