mikebridge commented on PR #44393:
URL: https://github.com/apache/superset/pull/44393#issuecomment-6129034568
@rusackas this is ready for another look whenever you have time. All three
of your points are fixed, and each has a regression test that fails without the
fix:
- **`query`/`saved_query` charts:** `update_chart` no longer raises for
them, so a plain rename on a SQL Lab or saved-query chart works again.
- **`datasource_id` + `datasource_type`:** `{"datasource_id": 5,
"datasource_type": "semantic_view"}` now resolves to semantic view 5, not table
dataset 5.
- **`metrics_b`:** a Mixed Timeseries chart's secondary-axis metric is now
checked against the target view on a semantic rebind.
The branch is up to date with master, CI is green, and the PR description
has been refreshed to the current head.
(Prepared with Codex and Claude.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
