mikebridge commented on code in PR #44393:
URL: https://github.com/apache/superset/pull/44393#discussion_r4252471896
##########
docs/admin_docs/configuration/mcp-server.mdx:
##########
@@ -327,6 +327,46 @@ Permissions and row-level security apply exactly as they
do without it.
---
+## Semantic-view chart targets
+
+`generate_chart` and `generate_explore_link` require exactly one source
selector:
+`dataset_id` for a table dataset, or `view_id` for a semantic view. View
selectors
+accept UUIDs or legacy numeric IDs. The numeric ID spaces are independent: a
+dataset ID must not be reused as a view ID.
+
+The legacy `datasource_id` alias defaults to a table when `datasource_type` is
+omitted. With `datasource_type: "semantic_view"`, it selects a view instead.
+For table-only requests, an explicit `dataset_id` takes precedence over
+`datasource_id`. Unsupported types and conflicting semantic selectors are
rejected.
+
+Semantic configurations use saved metric names, for example
+`{"name": "revenue", "saved_metric": true}`, and dimensions published by the
view.
+Ad-hoc aggregates and SQL expressions are rejected. Missing and inaccessible
+views return the same `view_not_found` error without exposing view metadata.
+
+`update_chart` accepts at most one replacement selector; omitting both retains
+the chart's source. A `view_id` rebind validates retained query roles; a
+`dataset_id` rebind, including from a view, requires a complete `config`.
Review Comment:
Good catch—applied your wording verbatim in
2a4ce72019676c39a3f79c06d62a21b67117956f. The saved-plugin guard covers both
selectors, so Gauge, Treemap and geographic charts require a complete config
for any actual rebind; the general dataset_id rule remains explicit. This is
documentation-only, with no behavior change. Eleven focused rebind tests and
the applicable hooks passed.
Implemented with Codex; independently reviewed with Claude.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
