eschutho commented on PR #44278: URL: https://github.com/apache/superset/pull/44278#issuecomment-6151957250
@rusackas thanks for the review. Updated: - **Rebased onto master** and repointed the migration's `down_revision` to master's current head, `c179af013f48`, so the graph has a single head again. `enforce-single-migration-head` and `Check DB migration conflict` both pass. - **Partial-run safety:** upgrade and downgrade log and skip any connection whose `extra` is not a valid JSON object instead of aborting partway through a batched run. Each migrated row gets its new URI and marker together, so a run that stops partway is safe to re-run. - **Scoped downgrade:** the marker records this revision and the row's id, and downgrade only reverts connector-driver rows whose marker matches both. A connection whose `extra` was copied from a migrated one keeps its connector driver. Both review threads are resolved, and the new cases are covered in `tests/unit_tests/migrations/test_migrate_databricks_odbc_to_connector.py`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
