codeant-ai-for-open-source[bot] commented on PR #45306:
URL: https://github.com/apache/superset/pull/45306#issuecomment-6180505052

   ## CodeAnt PR Risk: Medium Risk
   
   - The PR needs attention before merging because subtotal rollup selection 
may not match the displayed metric axis.
   - In utilities.ts, metricsOnRows ignores transposePivot even though rows and 
columns are swapped earlier, which can request the collapsed level on the wrong 
axis.
   - The new tests cover transposed combined metrics but not non-combined 
subtotals, where the axis mismatch could leave subtotal cells without query 
data.
   
   **Assessed commit:** `e66dbb106e1a`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to