mikebridge opened a new pull request, #45358: URL: https://github.com/apache/superset/pull/45358
Correct eight MCP tests that expect the wrong UTC offset for Dublin’s repeated 01:30. Production behavior is unchanged. ### SUMMARY **Background:** On 27 October 2024, Dublin’s clocks return from UTC+01:00 to UTC. The second occurrence of 01:30 (`fold=1`) is at UTC+00:00. **Problem:** The MCP table, dataset, chart-data and bullet tests expect UTC+01:00, or epoch milliseconds one hour too early. All eight affected tests fail on current master in the tested environment. **What this changes:** Correct the ISO offsets and matching numeric/string epoch expectations, preserving the producer fixtures and microsecond precision. Add brief comments explaining the repeated-hour case. Fixes [SC-126726](https://app.shortcut.com/preset/story/126726). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI change. The Dublin `fold=1` expectation changes from `2024-10-27T01:30:00.123456+01:00` to `2024-10-27T01:30:00.123456+00:00`; its epoch milliseconds change from `1729989000123.456` to `1729992600123.456`. ### TESTING INSTRUCTIONS Run: ```sh TZ=UTC pytest tests/unit_tests/mcp_service/chart/test_bullet_chart.py tests/unit_tests/mcp_service/chart/test_bullet_tool_paths.py tests/unit_tests/mcp_service/chart/tool/test_get_chart_data.py tests/unit_tests/mcp_service/dataset/tool/test_query_dataset.py tests/unit_tests/mcp_service/semantic_layer/tool/test_get_table.py -q ``` On base `e0e728ef76`: eight failures, 1,012 passes. After the fix: all 1,020 pass. The eight affected cases also pass with `TZ=America/Toronto`. Both dateutil and stdlib `zoneinfo` independently confirm the Dublin offset/instant. Changed-file pre-commit checks passed, including MyPy and Ruff. ### ADDITIONAL INFORMATION - [x] Has associated issue: SC-126726 - [ ] Required feature flags - [ ] Changes UI - [ ] Includes DB Migration - [ ] Introduces new feature or API - [ ] Removes existing feature or API Authored with Codex assistance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
