aminghadersohi commented on code in PR #45358:
URL: https://github.com/apache/superset/pull/45358#discussion_r4289383785
##########
tests/unit_tests/mcp_service/dataset/tool/test_query_dataset.py:
##########
@@ -497,6 +497,19 @@ async def
test_query_dataset_normalizes_supported_producer_timezones(
dataset = _make_dataset(
columns=[_make_column("created_at", is_dttm=True)],
)
+ dublin_fold: datetime = datetime(
+ 2024,
+ 10,
+ 27,
+ 1,
+ 30,
+ 0,
+ 123456,
+ tzinfo=dateutil_tz.gettz("Europe/Dublin"),
+ fold=1,
Review Comment:
Nit: dateutil's tzfile ignores `fold` for Europe/Dublin, so this resolves to
+01:00 either way, and production's ambiguity branch is unreached for this
instant — no fixture here exercises fold selection. A zoneinfo-backed value
would.
##########
tests/unit_tests/mcp_service/chart/test_bullet_tool_paths.py:
##########
@@ -1611,12 +1615,12 @@ async def
test_bullet_timestamp_categories_from_dataframe_reach_fastmcp(
"-0.0010000000000287557",
"1704153600000",
"null",
- "1729989000123.456",
+ str(dublin_epoch_ms),
Review Comment:
Nit: `str()` is not production number formatting: at a whole-millisecond
instant it yields `1729989000000.0` where the chart emits `1729989000000` — the
spelling the hard-coded siblings here already use. It agrees only while this
fixture keeps microseconds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
