mikebridge commented on code in PR #45358:
URL: https://github.com/apache/superset/pull/45358#discussion_r4289528334
##########
tests/unit_tests/mcp_service/chart/test_bullet_tool_paths.py:
##########
@@ -1611,12 +1615,12 @@ async def
test_bullet_timestamp_categories_from_dataframe_reach_fastmcp(
"-0.0010000000000287557",
"1704153600000",
"null",
- "1729989000123.456",
+ str(dublin_epoch_ms),
Review Comment:
Codex: addressed in
[2f61887b36](https://github.com/apache/superset/commit/2f61887b363d92563d77084d5ad87fc231c2977a).
The expected labels now use the chart’s `_javascript_number_string` instead of
`str()`, including the equivalent preview-only case.
`test_bullet_dateutil_categories_preserve_chart_data_selected_instants` and
`test_bullet_timestamp_categories_from_dataframe_reach_fastmcp` both cover zero
and nonzero microseconds, with ASCII and Vega-Lite in the latter. The new
whole-millisecond cases failed before this change; all 1,024 tests across the
five affected files pass with both timezone sources, and changed-file hooks
pass.
##########
tests/unit_tests/mcp_service/dataset/tool/test_query_dataset.py:
##########
@@ -497,6 +497,19 @@ async def
test_query_dataset_normalizes_supported_producer_timezones(
dataset = _make_dataset(
columns=[_make_column("created_at", is_dttm=True)],
)
+ dublin_fold: datetime = datetime(
+ 2024,
+ 10,
+ 27,
+ 1,
+ 30,
+ 0,
+ 123456,
+ tzinfo=dateutil_tz.gettz("Europe/Dublin"),
+ fold=1,
Review Comment:
Codex: addressed in
[2f61887b36](https://github.com/apache/superset/commit/2f61887b363d92563d77084d5ad87fc231c2977a).
`test_query_dataset_normalizes_supported_producer_timezones` keeps the
dateutil fixture and adds a ZoneInfo-backed Dublin value, parametrized over
fold 0 and fold 1 with explicit +01:00 and +00:00 expectations. A test-only
mutation forcing ZoneInfo values to fold 0 fails the fold-1 case while the
fold-0 case passes, so the assertion detects lost fold selection. All 1,024
tests across the five affected files pass under both timezone sources. I also
inspected the latest red CI job (38813986056/116694240639): it reached 99% and
ended with a runner shutdown/cancellation message, without a test-failure
summary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
