fitzee commented on PR #45311: URL: https://github.com/apache/superset/pull/45311#issuecomment-6242997748
Reviewed both sets of feedback against the latest branch. The existing 63f63d0 commit fixes integer CSV precision (including values above 2^53), adds the UPDATING.md entry, covers Sum/Average and combined/transposed layouts, corrects the stale denominator comments, and narrows the all-empty-rollup claim to percentage modes. I verified those changes locally. Pushed c7f29d2 to finish the remaining cleanup: `_collapsed_metric` now reuses the precomputed set without copying or mutating it; combined/transposed subtotal tests also cover metrics on rows with a single-metric control; the remaining collapse docstring explicitly refers to the proposed browser change. Validation: **433 passed, 2 xfailed** in the full charts unit suite, and all changed-file pre-commit checks pass (including mypy, Ruff and Pylint). The post-#44657 integration recheck remains pending because that PR is still open. This stays draft; after it lands, we still need to update against master and rerun the non-Sum cases plus hosted export/report checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
