fitzee commented on PR #45311:
URL: https://github.com/apache/superset/pull/45311#issuecomment-6282116588

   @mikebridge Addressed the four items in 
39f624d906a204376732b8cd1a91a5c3abe5c0df:
   
   - Converted the UPDATING.md entry to a bullet, preserving the other upgrade 
notes.
   - Updated the matrix to expect Total (Average) when Average is selected, 
including with Show values as set.
   - Reworded `_reduce`'s docstring around all-NULL percentage rollups, 
removing the mixed-slot example.
   - Limited the description's precision claim to dense, all-integer pivots; 
sparse and mixed integer/float behavior remains unchanged from master.
   
   https://github.com/apache/superset/pull/44657 has merged, so I merged 
current master into this reviewed branch without rewriting its history and 
reran the combined chart suite: **457 passed, 2 xfailed**. Changed-file 
pre-commit checks pass, including mypy, Ruff and Pylint. Only the intended 
three files differ from current master.
   
   CI on the new head is pending. Hosted CSV/Excel and scheduled-report 
verification remains outstanding. The PR's existing ready-for-review state is 
unchanged.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to