villebro commented on code in PR #45402:
URL: https://github.com/apache/superset/pull/45402#discussion_r4308053038
##########
superset/coordination/cache_backend.py:
##########
@@ -408,6 +409,12 @@ def __init__( # pylint: disable=too-many-arguments
master_kwargs["socket_connect_timeout"] = socket_connect_timeout
master_kwargs["protocol"] = 2
+ # The coordination commands run on this master connection rather than
+ # on the flask-caching client, so the DB and ACL user must be set here.
+ master_kwargs["db"] = db
+ if username:
+ master_kwargs["username"] = username
Review Comment:
Not changing this. The existing code already treats Sentinel-node auth and
data-node auth as separate credentials: `sentinel_kwargs` carries
`sentinel_password` (from `CACHE_REDIS_SENTINEL_PASSWORD`), while `password`
goes only to `master_for`. `CACHE_REDIS_USER` is the ACL user for the data
(master) connection, paired with `CACHE_REDIS_PASSWORD`, so forwarding it to
the Sentinel nodes would pair it with the wrong password and could break
discovery for deployments where the data user does not exist on the Sentinels.
A Sentinel-node username would need its own config key (e.g. a
sentinel-specific counterpart), which is out of scope for this fix and not an
existing option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
