codeant-ai-for-open-source[bot] commented on code in PR #45402:
URL: https://github.com/apache/superset/pull/45402#discussion_r4308055206
##########
superset/coordination/cache_backend.py:
##########
@@ -408,6 +409,12 @@ def __init__( # pylint: disable=too-many-arguments
master_kwargs["socket_connect_timeout"] = socket_connect_timeout
master_kwargs["protocol"] = 2
+ # The coordination commands run on this master connection rather than
+ # on the flask-caching client, so the DB and ACL user must be set here.
+ master_kwargs["db"] = db
+ if username:
+ master_kwargs["username"] = username
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Keep Sentinel-node authentication separate from data-node ACL credentials;
do not forward `CACHE_REDIS_USER` to Sentinel nodes. Sentinel ACL
authentication requires a separate Sentinel-specific configuration option.
**Applied to:**
- `superset/coordination/cache_backend.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
