mikebridge commented on code in PR #45471:
URL: https://github.com/apache/superset/pull/45471#discussion_r4327085618
##########
superset-frontend/src/features/versionHistory/SaveGroupItem.tsx:
##########
@@ -338,20 +327,11 @@ export default function SaveGroupItem({
aria-label={hasRecords ? headline : undefined}
hasRecords={hasRecords}
>
- <IconWrapper isCurrent={isCurrent}>
- {/* Semantic group icons per the design: the current (live)
- version is a check-circle, saved snapshots a save icon. */}
- {isCurrent ? (
- <Icons.CheckCircleOutlined iconSize="l" />
- ) : (
- <Icons.SaveOutlined iconSize="l" />
- )}
+ <IconWrapper>
+ <Icons.SaveOutlined iconSize="l" />
</IconWrapper>
<HeaderText>
- <HeadlineRow>
- <Headline title={headline}>{headline}</Headline>
- {currentTag}
- </HeadlineRow>
+ <Headline title={headline}>{headline}</Headline>
Review Comment:
Added the subdued “Latest save” text in 6e2ce6d782b5, using the existing
metadata styling rather than a tag. It stays visible when unsaved edits show
the Current version section. The latest save still has no Restore action; I
also corrected the stale ActionRow highlight comment.
##########
superset-frontend/src/features/versionHistory/SaveGroupItem.tsx:
##########
@@ -324,6 +312,7 @@ export default function SaveGroupItem({
return (
<Container
isHighlighted={isHighlighted}
+ aria-current={marksCurrentState ? 'true' : undefined}
Review Comment:
Fixed in 6e2ce6d782b5. aria-current is on the focusable Header when it has
records, with a regression that focuses that button and checks its state.
Record-free groups keep a plain text label without a no-op focus target. The
Playwright selector is updated too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
