fitzee commented on code in PR #45471:
URL: https://github.com/apache/superset/pull/45471#discussion_r4330805399
##########
superset-frontend/src/features/versionHistory/SaveGroupItem.tsx:
##########
@@ -336,23 +324,23 @@ export default function SaveGroupItem({
onKeyDown={hasRecords ? activate(toggleExpanded) : undefined}
aria-expanded={hasRecords ? expanded : undefined}
aria-label={hasRecords ? headline : undefined}
+ aria-current={hasRecords && marksCurrentState ? 'true' : undefined}
hasRecords={hasRecords}
>
- <IconWrapper isCurrent={isCurrent}>
- {/* Semantic group icons per the design: the current (live)
- version is a check-circle, saved snapshots a save icon. */}
- {isCurrent ? (
- <Icons.CheckCircleOutlined iconSize="l" />
- ) : (
- <Icons.SaveOutlined iconSize="l" />
- )}
+ <IconWrapper>
+ <Icons.SaveOutlined iconSize="l" />
</IconWrapper>
<HeaderText>
- <HeadlineRow>
- <Headline title={headline}>{headline}</Headline>
- {currentTag}
- </HeadlineRow>
- <Meta>{meta}</Meta>
+ <Headline title={headline}>{headline}</Headline>
+ <Meta>
+ {isCurrent && (
+ <>
+ <span>{t('Latest save')}</span>
Review Comment:
**non-blocking (a11y):** Screen readers never read this label from the
header. `Header` has `aria-label={headline}`, which replaces the text inside it
as the button's accessible name. For the newest save with records, the name is
just the date ("Aug 31, 2026, 1:46 PM"), with no "Latest save". That leaves out
keyboard/screen-reader users in exactly the case the label was added for:
unsaved edits or a restore notice, when `marksCurrentState` is false and
there's no `aria-current` either. Fix by putting it in the name, e.g.
`aria-label={isCurrent ? t('%s, latest save', headline) : headline}`, or by
pointing `aria-describedby` at `Meta`. The second option would also announce
the author and date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
