mikebridge commented on code in PR #45471:
URL: https://github.com/apache/superset/pull/45471#discussion_r4330987182
##########
superset-frontend/src/features/versionHistory/SaveGroupItem.tsx:
##########
@@ -336,23 +324,23 @@ export default function SaveGroupItem({
onKeyDown={hasRecords ? activate(toggleExpanded) : undefined}
aria-expanded={hasRecords ? expanded : undefined}
aria-label={hasRecords ? headline : undefined}
+ aria-current={hasRecords && marksCurrentState ? 'true' : undefined}
hasRecords={hasRecords}
>
- <IconWrapper isCurrent={isCurrent}>
- {/* Semantic group icons per the design: the current (live)
- version is a check-circle, saved snapshots a save icon. */}
- {isCurrent ? (
- <Icons.CheckCircleOutlined iconSize="l" />
- ) : (
- <Icons.SaveOutlined iconSize="l" />
- )}
+ <IconWrapper>
+ <Icons.SaveOutlined iconSize="l" />
</IconWrapper>
<HeaderText>
- <HeadlineRow>
- <Headline title={headline}>{headline}</Headline>
- {currentTag}
- </HeadlineRow>
- <Meta>{meta}</Meta>
+ <Headline title={headline}>{headline}</Headline>
+ <Meta>
+ {isCurrent && (
+ <>
+ <span>{t('Latest save')}</span>
Review Comment:
Fixed in a5323e58499c8578598e25e43b82a8490df39096. The focusable header now
uses aria-describedby to reference its metadata, exposing “Latest save”
together with the author and timestamp while retaining the headline as its
accessible name. The regression covers both aria-current states, including the
case where unsaved edits or a restore notice occupy the Current version
section, and checks that a historical group's description does not inherit the
latest-save label. Both focused suites pass (43 tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
