sadpandajoe commented on code in PR #44878:
URL: https://github.com/apache/superset/pull/44878#discussion_r4337750330
##########
superset-frontend/src/explore/components/ExploreViewContainer/index.tsx:
##########
@@ -844,6 +870,18 @@ function ExploreViewContainer(props:
ExploreViewContainerProps) {
}
}, [props.controls, props.ownState]);
+ useEffect(
+ () => () => {
Review Comment:
Nothing exercises this unmount cleanup: none of the new race tests unmounts
the container while a margin timer is pending, so deleting both `clearTimeout`
calls leaves the suite green. Without it, a title added with margin 0 and then
a navigation away inside the 250 ms window would still dispatch the
programmatic margin 30 from the departed container. Could a test add a title,
unmount before the timer elapses, advance timers, and assert no programmatic
`x_axis_title_margin` / `y_axis_title_margin` write happens?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
