codeant-ai-for-open-source[bot] commented on code in PR #45599:
URL: https://github.com/apache/superset/pull/45599#discussion_r4343984741
##########
superset-frontend/src/dashboard/util/risonFilters.ts:
##########
@@ -490,6 +490,11 @@ function convertRisonToNativeValue(
}
return comparator;
+ case 'filter_condition':
+ return Array.isArray(comparator) && !['IN', 'NOT IN'].includes(operator)
+ ? { op: operator, val: comparator[0] }
+ : { op: operator, val: comparator };
Review Comment:
**Suggestion:** A URL `BETWEEN` becomes an unsupported Condition operator
while its extra form data still applies both bounds, leaving charts filtered by
a condition the control cannot represent.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c5905ea16ec64571947c7e6f0fbb193f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c5905ea16ec64571947c7e6f0fbb193f&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/dashboard/util/risonFilters.ts
**Line:** 493:496
**Comment:**
*Api Mismatch: A URL `BETWEEN` becomes an unsupported Condition
operator while its extra form data still applies both bounds, leaving charts
filtered by a condition the control cannot represent.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45599&comment_hash=86b77fe1fbba3147c8cfc9a744b87267326fdad2cd383f791494a14392ef4624&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45599&comment_hash=86b77fe1fbba3147c8cfc9a744b87267326fdad2cd383f791494a14392ef4624&reaction=dislike'>๐</a>
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/constants.ts:
##########
@@ -35,6 +35,12 @@ export const FILTER_SUPPORTED_TYPES = {
GenericDataType.Temporal,
],
filter_range: [GenericDataType.Numeric],
+ filter_condition: [
+ GenericDataType.Boolean,
+ GenericDataType.String,
+ GenericDataType.Numeric,
+ GenericDataType.Temporal,
+ ],
Review Comment:
**Suggestion:** Array columns use `GenericDataType.MultiValue`, which
Condition supports for null checks, but this allowlist rejects them, preventing
builders from configuring Condition filters for arrays.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Type error`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=c74ffefbe9624787b49e9a5ca50f1389&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=c74ffefbe9624787b49e9a5ca50f1389&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/constants.ts
**Line:** 38:43
**Comment:**
*Type Error: Array columns use `GenericDataType.MultiValue`, which
Condition supports for null checks, but this allowlist rejects them, preventing
builders from configuring Condition filters for arrays.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45599&comment_hash=234e9dd0c3974caf4ec4a7b7fd70824bf50b034d1f762487552f612e70ca16ce&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45599&comment_hash=234e9dd0c3974caf4ec4a7b7fd70824bf50b034d1f762487552f612e70ca16ce&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
