yuskhan commented on code in PR #45599:
URL: https://github.com/apache/superset/pull/45599#discussion_r4344082541
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/constants.ts:
##########
@@ -35,6 +35,12 @@ export const FILTER_SUPPORTED_TYPES = {
GenericDataType.Temporal,
],
filter_range: [GenericDataType.Numeric],
+ filter_condition: [
+ GenericDataType.Boolean,
+ GenericDataType.String,
+ GenericDataType.Numeric,
+ GenericDataType.Temporal,
+ ],
Review Comment:
This is on purpose, so I'm leaving it as is. The Condition filter's query
groups and orders by the column to suggest values, and several databases can't
group or order by array columns. That matches `filter_select`, which also
leaves out MultiValue. The MultiValue entry in `OPERATORS_BY_TYPE` is there
because the `Record<GenericDataType, …>` type needs every key. It also covers a
column whose type becomes an array after the filter was set up, which is then
limited to null checks. Supporting array columns would need a different query,
so I'd rather leave that for a follow-up.
---
_Generated by [Claude Code](https://claude.ai/code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
