yuskhan commented on code in PR #45599:
URL: https://github.com/apache/superset/pull/45599#discussion_r4344085395
##########
superset-frontend/src/dashboard/util/risonFilters.ts:
##########
@@ -490,6 +490,11 @@ function convertRisonToNativeValue(
}
return comparator;
+ case 'filter_condition':
+ return Array.isArray(comparator) && !['IN', 'NOT IN'].includes(operator)
+ ? { op: operator, val: comparator[0] }
+ : { op: operator, val: comparator };
Review Comment:
Confirmed, fixed in ce07afa. `?f=(price:(between:!(1,10)))` set the filter
state to `{op: 'BETWEEN', val: 1}`, which the Condition filter can't show,
while both bounds were still applied. A Condition filter only holds one
operator, so a URL operator it doesn't support now stays unmatched. It still
applies to the charts the same way as a URL filter with no matching native
filter, and the filter state no longer disagrees with what's applied. Added a
test for it.
---
_Generated by [Claude Code](https://claude.ai/code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
