codeant-ai-for-open-source[bot] commented on code in PR #45601:
URL: https://github.com/apache/superset/pull/45601#discussion_r4344074935
##########
.github/workflows/caches.js:
##########
@@ -35,6 +35,25 @@ const assetsConfig = {
};
// Multi-layer cache definition
+// A pg_dump of the metadata + examples database the Playwright jobs load with
+// `superset load_examples`. Keyed on everything that shapes that data: the
+// example loaders and their YAML configs, migrations, the CLI commands that
+// run, the CI config, and the E2E workflow itself (it pins the Postgres image
+// the dump has to match).
+const playwrightTestdataConfig = {
+ path: ['/tmp/superset-playwright-testdata'],
+ hashFiles: [
+ `${workspaceDirectory}/superset/examples/**/*`,
+ `${workspaceDirectory}/superset/migrations/**/*`,
+ `${workspaceDirectory}/superset/cli/examples.py`,
+ `${workspaceDirectory}/superset/cli/test.py`,
+ `${workspaceDirectory}/tests/integration_tests/superset_test_config.py`,
+ `${workspaceDirectory}/.github/workflows/superset-e2e.yml`,
+ `${workspaceDirectory}/.github/workflows/bashlib.sh`,
+ ],
Review Comment:
**Suggestion:** `load_examples` also depends on importer logic in
`superset/examples/utils.py` and `superset/commands/importers/v1/**`, which is
not hashed, so changes there can reuse a stale dump.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Cache`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=7ac62395528747d09a6df96721f2bd83&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=7ac62395528747d09a6df96721f2bd83&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/caches.js
**Line:** 45:53
**Comment:**
*Cache: `load_examples` also depends on importer logic in
`superset/examples/utils.py` and `superset/commands/importers/v1/**`, which is
not hashed, so changes there can reuse a stale dump.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45601&comment_hash=6e54af576522eb36e9b48870c127c434c38e13df6df2e2489eb0176b43c387fe&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45601&comment_hash=6e54af576522eb36e9b48870c127c434c38e13df6df2e2489eb0176b43c387fe&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
