geido commented on code in PR #45601:
URL: https://github.com/apache/superset/pull/45601#discussion_r4349908360
##########
.github/workflows/superset-e2e.yml:
##########
@@ -119,6 +119,21 @@ jobs:
uses: ./.github/actions/cached-dependencies # zizmor:
ignore[self-repository] - $/ cannot resolve an action that lives in a
submodule; ./ is required here
with:
run: setup-postgres
+ # A pg_dump of the loaded examples database. Keyed on everything that
+ # shapes the loaded rows: every backend Python file (loaders, importers,
+ # models), the example configs, migrations, the dependency pins, the CI
+ # config, and this workflow (it pins the Postgres image). The post-job
+ # save only happens on a miss; `playwright_testdata` in bashlib.sh
+ # restores the dump on a hit and writes it on a miss.
+ - name: Restore cached examples dump
+ uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
+ with:
+ path: /tmp/superset-playwright-testdata
+ key: >-
+ playwright-testdata-${{ hashFiles('superset/**/*.py',
'!superset/**/__pycache__/**',
+ 'superset/examples/**', 'superset/migrations/**',
'requirements/*.txt',
Review Comment:
I think a filename-only change can leave this key unchanged: `hashFiles`
digests file contents but not paths. Renaming `Items_Sold.yaml` to
`Items_Sold.test.yaml` would make `load_examples` skip that chart, while a hit
still restores it. Could the key include the paths too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
