sadpandajoe commented on code in PR #45608:
URL: https://github.com/apache/superset/pull/45608#discussion_r4345126395
##########
.github/workflows/superset-e2e.yml:
##########
@@ -135,6 +135,21 @@ jobs:
node-version-file: "./superset-frontend/.nvmrc"
cache: "npm"
cache-dependency-path: "superset-frontend/package-lock.json"
+ # The instrumented production assets, keyed on the frontend sources and
+ # lockfile. `build-instrumented-assets` skips the webpack build when the
+ # manifest is already there. (The cached-dependencies helpers that used
+ # to cache these call a retired cache API and never saved anything, so
+ # every Playwright job was rebuilding.)
+ - name: Restore instrumented assets
+ uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
+ with:
+ path: superset/static/assets
Review Comment:
On a cache hit, `manifest.json` makes `build-instrumented-assets` skip
webpack, but the build also writes `superset/static/service-worker.js` (the
`../service-worker.js` output in `webpack.config.js`), which lives outside
`superset/static/assets` and is never cached. On a fresh runner the worker is
missing, so `spa.html` registration 404s and logs a console error on every
page, and the app is no longer served by the same build the cache was produced
from. Should `superset/static/service-worker.js` be added to this `path:` (here
and in the `playwright-tests-gaq` job) so a hit restores the full webpack
output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
